-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): save cache on no-cuda
jobs and restore cache only on cuda
jobs
#4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
5 tasks
xmfcx
reviewed
Jul 4, 2024
6 tasks
xmfcx
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary in #4945 (comment)
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Jul 5, 2024
* feat(ci): save cache on `no-cuda` jobs and restore cache only on `cuda` jobs (autowarefoundation#4945) * feat(ci): rename `docker build` workflows (autowarefoundation#4947) * cache only on no-cuda Signed-off-by: Yutaka Kondo <[email protected]> * version up Signed-off-by: Yutaka Kondo <[email protected]> * version up Signed-off-by: Yutaka Kondo <[email protected]> * rename Signed-off-by: Yutaka Kondo <[email protected]> * rename Signed-off-by: Yutaka Kondo <[email protected]> * rename to health-check Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> * refactor(ci): refactor `docker-build-and-push` action (autowarefoundation#4948) * cache only on no-cuda Signed-off-by: Yutaka Kondo <[email protected]> * version up Signed-off-by: Yutaka Kondo <[email protected]> * version up Signed-off-by: Yutaka Kondo <[email protected]> * rename Signed-off-by: Yutaka Kondo <[email protected]> * rename Signed-off-by: Yutaka Kondo <[email protected]> * rename to health-check Signed-off-by: Yutaka Kondo <[email protected]> * refactor action Signed-off-by: Yutaka Kondo <[email protected]> * remove old comment Signed-off-by: Yutaka Kondo <[email protected]> * revert free disk Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]> --------- Signed-off-by: Yutaka Kondo <[email protected]>
pravinkmr26
pushed a commit
to pravinkmr26/autoware
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4944
This PR saves the
buildkit-cache-dance
cache only onno-cuda
jobs and only restore the cache oncuda
jobs.Tests performed
https://github.com/youtalk/autoware/actions/runs/9786429625
actions/cache
was called onno-cuda
job: https://github.com/youtalk/autoware/actions/runs/9786429625/job/27021289733#step:5:374actions/cache/restore
was called oncuda
job: https://github.com/youtalk/autoware/actions/runs/9786429625/job/27021289893#step:5:374Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.